[주변상점] 기본 이미지 오류 수정 #318
Merged
[주변상점] 기본 이미지 오류 수정 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2024 17:37
ChoiWonBeen
reviewed
May 7, 2024
Comment on lines
+40
to
+48
| if (hiddenInfo) { | ||
| return ( | ||
| <img | ||
| src="https://static.koreatech.in/assets/img/mainlogo2.png" | ||
| alt="KOIN service logo" | ||
| className={styles.eventThumbail} | ||
| /> | ||
| ); | ||
| } |
There was a problem hiding this comment.
hiddenInfo라면 로고를 띄운다..? 이게 무슨 뜻인가요?
There was a problem hiding this comment.
전체보기가 아닌경우를 의미합니다.
전체보기가 아닌경우 현재 코인로고를 보여주고있어서 이렇게 작성하였습니다.
There was a problem hiding this comment.
변수명이랑 매치가 잘 안되는 것 같아요. 프로퍼티를 변경하거나, 주석을 추가해두면 좋을거같네용
added 2 commits
May 7, 2024 18:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
기본 이미지가 변경되고 이전에 생기면 이미지 src오류를 해결하였습니다.
ScreenShot 📷
Test CheckList ✅
Precaution
코인과 동일한 UI인지 확인 바랍니다.
✔️ Please check if the PR fulfills these requirements
developbranch, not themainbranchdevelopbranch?