-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[가게 등록] 가게 등록 페이지 PC 버전 로직 구현 및 API 구현 #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 스크롤 가능할 때 헤더가 따라오도록 sticky 속성 추가 - overflow 될 때 스크롤바 삭제
- categoryState를 배열로 수정 - 운영시간 값에 null 추가
dooohun
requested review from
hanagertrudeKim,
HAEROOL,
hoooooony,
MinGu-Jeong and
daepan
as code owners
November 12, 2023 14:20
MinGu-Jeong
requested changes
Nov 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!!! 굉장히 노력이 많이 들어간 코드처럼 보이네요😀
리뷰와 별개로 몇가지 이슈가 있습니다.
- 기타정보 미입력 시 422에러가 발생해서(기타정보는 1자 이상이어야합니다) 다음페이지로 넘어갈 수 없는데, 요건 API가 그렇기 때문에 어쩔 수 없는거 같지만, 사실 기타정보가 필수적으로 입력되어져야하나..? 라고 생각하면 아닌거 같아서 이건 다음 회의때 얘기해봐야 할 것 같아요. 만약 API 수정없이 진행한다고 하면 기타정보나 다른 정보를 입력안해서 다음페이지로 넘어가지 않을 때 적절한 UI를 보여줘야 할 것 같아요! 지금 상태로는 다음 페이지로 넘어가지 못하는 이유를 알기 힘들어요.
- 추가적으로 가게명을 정상적으로 입력했는데도 아래 사진과 같은 에러가 발생하는데 확인부탁드립니다!
- 가게를 등록하는 페이지인데 가게검색 기능이 있는게 좀 이상하죠..? 어떤 의도로 가게등록 페이지에 가게검색 기능이 있는지 회의시간에 한 번 얘기 해봐야할 것 같습니다.
- 코드리뷰하면서 느낀건데 저희 프로젝트 전체적으로 store과 shop이 혼용되는 느낌인데 통일해야 할 필요성이 있어보여요..! 이것도 회의때 얘기 해보면 좋을 것 같습니다.
수고하셨어요😀
src/page/StoreRegistration/component/Modal/SearchStore/index.tsx
Outdated
Show resolved
Hide resolved
@hoooooony 리뷰 남겨주신 전화번호 입력 부분은 값을 입력하면 하이픈이 추가되도록 기능을 추가했습니다! bbdff93 |
hoooooony
approved these changes
Nov 27, 2023
junghaesung79
approved these changes
Nov 28, 2023
daepan
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다.
MinGu-Jeong
approved these changes
Nov 29, 2023
hanagertrudeKim
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#27] request
[주요 구현사항]
SearchStore
가게 검색 기능Please check if the PR fulfills these requirements
develop
branch, not themain
branchdeveop
branch?Screenshot
Precautions (main files for this PR ...)