Fix: 모달 창 안 뜨는 문제 해결 #231
Merged
Fix: 모달 창 안 뜨는 문제 해결 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiWonBeen
reviewed
Apr 10, 2024
| @@ -135,7 +135,7 @@ export default function Login() { | |||
| </div> | |||
| </form> | |||
| </div> | |||
| {loginErrorCode === 100005 && isModalOpen && <ApprovalModal toggle={toggle} />} | |||
| {loginErrorStatus === 403 && isModalOpen && <ApprovalModal toggle={toggle} />} | |||
There was a problem hiding this comment.
요거 KoinError타입이랑 아직 동기화안돼있죠?
There was a problem hiding this comment.
동기화 안 됐다는 게 무슨 소리인지 알 수 있을까요? 동기화가 되나요..?
ChoiWonBeen
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch, not themainbranchdevelopbranch?