New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 에러를 쓰고있는쪽에서 변경된 error interface에 맞지 않는 문제 대응 #229

Merged

ChoiWonBeen merged 1 commit into main from fix/#228-error-object-not-match

Apr 10, 2024

Member

ChoiWonBeen commented Apr 10, 2024 •

edited

Loading

Close 회원가입 중 이메일인증 실패시 클라이언트가 터짐 #228

What is this PR? 🔍

핫픽스입니다.
isKoinError를 사용하기 위해 error의 인터페이스를 새로운 객체로 수정했는데,
기존에 error객체를 쓰고있던쪽에서 error.response.data.~~~ 구조로 쓰고있어
해당 객체에 koinError타입으로 변경합니다.

변경하는김에 @bcsdlab/koin 라이브러리도 설치했어요


          fix: 에러를 쓰고있는쪽에서 변경된 error interface에 맞지 않는 문제 대응

654f7f1

github-actions bot requested review from KimKyungYun and MinGu-Jeong

April 10, 2024 12:34

MinGu-Jeong approved these changes

View reviewed changes

ChoiWonBeen merged commit e3d6aa2 into main

2 checks passed

KimKyungYun approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet