Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[영양사] 식단 이미지 업로드 presigned-url 적용 #226

Merged
merged 3 commits into from
Apr 10, 2024
Merged

[영양사] 식단 이미지 업로드 presigned-url 적용 #226

merged 3 commits into from
Apr 10, 2024

Conversation

MinGu-Jeong
Copy link
Contributor

@MinGu-Jeong MinGu-Jeong commented Apr 9, 2024 •
edited
Loading

What is this PR? 🔍

Changes 📝

  • 식단 이미지 업로드에 presigned url이 적용되었습니다.
  • 기존에 클라이언트와 서버상태로 관리되던 이미지 상태를 서버상태로만 관리하도록 수정했습니다.

ScreenShot 📷

2024-04-10.2.16.40.mov

Test CheckList ✅

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • Did you merge recent develop branch?

@MinGu-Jeong MinGu-Jeong added the ✨ Feature 기능 개발 label Apr 9, 2024
@MinGu-Jeong MinGu-Jeong self-assigned this Apr 9, 2024
KimKyungYun
KimKyungYun approved these changes Apr 10, 2024
View reviewed changes
Copy link

@KimKyungYun KimKyungYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 따로 제가 리뷰할만한 내용을 찾지못해서 바로 Approve하겠습니다!

@MinGu-Jeong MinGu-Jeong merged commit b887435 into develop Apr 10, 2024
1 check passed
@MinGu-Jeong MinGu-Jeong deleted the feature/#197-add-image-upload-logic branch April 10, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimKyungYun KimKyungYun KimKyungYun approved these changes

@chaeseungyun chaeseungyun Awaiting requested review from chaeseungyun

Assignees

@MinGu-Jeong MinGu-Jeong

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[영양사]영양사님 페이지 구현
2 participants
@MinGu-Jeong @KimKyungYun