Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[영양사]사장님, 영양사 url 분기 생성 #220

Merged
merged 26 commits into from
Apr 9, 2024
Merged

[영양사]사장님, 영양사 url 분기 생성 #220

merged 26 commits into from
Apr 9, 2024

Conversation

junghaesung79
Copy link
Contributor

@junghaesung79 junghaesung79 commented Mar 29, 2024 •
edited
Loading

What is this PR? 🔍

Changes 📝

  • 로그인 시 반환되는 userType을 전역 변수로 두었습니다.
  • 예시 coop 페이지를 만들었습니다.(url 리다이렉트 확인 용도)

24.4.9

  • 리뷰들을 수정하는 동안 api가 추가되고, 로직을 부분 변경하는 등의 변경사항이 있습니다.
  • 로그인 되지 않은 상태를 null로 표현하도록 바꿨습니다.
  • 테스트 하실 때 직접 yarn start 하셔서 확인해주시면 감사하겠습니다!
  • 지금까지 무한루프 도는 경우가 많았습니다. 해결하긴 했는데 제가 모르는 곳에서 또 문제가 있을 수도 있으니 테스트 바랍니다..

ScreenShot 📷

Test CheckList ✅

  • ProtectedRoute에 따라 다른 url로 리다이렉트 확인

Precaution

예시로 만들어낸 경로는 추후 페이지 담당자가 원하는 대로 수정하게 될 것입니다.
생협 테스트 계정
id : [email protected]
pw : coop

✔️ Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • Did you merge recent develop branch?

@junghaesung79 junghaesung79 added the ✨ Feature 기능 개발 label Mar 29, 2024
@junghaesung79 junghaesung79 self-assigned this Mar 29, 2024
@github-actions github-actions bot requested review from dooohun and MinGu-Jeong March 30, 2024 06:09
@junghaesung79 junghaesung79 changed the title Feature/#199 [영양사]사장님, 영양사 url 분기 생성 Mar 30, 2024
ChoiWonBeen
ChoiWonBeen reviewed Mar 30, 2024
View reviewed changes
src/App.tsx Outdated Show resolved Hide resolved
MinGu-Jeong
MinGu-Jeong requested changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@MinGu-Jeong MinGu-Jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!
회원권한에 따른 예외처리 부분만 수정해주시면 될 것 같아요

src/App.tsx Outdated Show resolved Hide resolved
src/model/auth/index.ts Outdated Show resolved Hide resolved
src/query/auth.ts Outdated Show resolved Hide resolved
ChoiWonBeen
ChoiWonBeen reviewed Mar 30, 2024
View reviewed changes
src/App.tsx Outdated Show resolved Hide resolved
ChoiWonBeen
ChoiWonBeen reviewed Mar 30, 2024
View reviewed changes
src/query/auth.ts Outdated Show resolved Hide resolved
@MinGu-Jeong MinGu-Jeong mentioned this pull request Apr 8, 2024
Merged
4 tasks
@MinGu-Jeong
Copy link
Contributor

수정완료되면 Re-request review 부탁드려요🙏

@junghaesung79
Copy link
Contributor Author

지금 생협 계정으로 /coop 경로로 들어가면 로그아웃 버튼이 없어서 테스트에 번거로움이 있습니다. 그때 로그아웃하기 위해서는 로컬/세션스토리지의 리프레시, 액세스 토큰을 delete하시고 새로고침하시거나 /login 경로 쳐서 들어가면 됩니다!

KimKyungYun
KimKyungYun reviewed Apr 9, 2024
View reviewed changes
Copy link

@KimKyungYun KimKyungYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 궁금한점 간단하게 남겼습니다!

src/layout/AuthLayout/index.tsx Show resolved Hide resolved
src/query/auth.ts Show resolved Hide resolved
ChoiWonBeen
ChoiWonBeen approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@ChoiWonBeen ChoiWonBeen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

영양사, 사장님 각각 로그인과

서비스중인 url로 직접 진입시 자동로그인 후,원래 url로 리다이렉트만 잘 되는게 확인됐다면 늦지않게 병합해야할 것 같네여

@junghaesung79 junghaesung79 merged commit a497bc9 into develop Apr 9, 2024
1 check passed
@junghaesung79 junghaesung79 deleted the feature/#199 branch April 9, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimKyungYun KimKyungYun KimKyungYun approved these changes

@MinGu-Jeong MinGu-Jeong MinGu-Jeong approved these changes

@ChoiWonBeen ChoiWonBeen ChoiWonBeen approved these changes

@hoooooony hoooooony Awaiting requested review from hoooooony

@dooohun dooohun Awaiting requested review from dooohun

Assignees

@junghaesung79 junghaesung79

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[영양사]코인 사장님에서 영양사님 권한으로 분기 생성
4 participants
@junghaesung79 @MinGu-Jeong @ChoiWonBeen @KimKyungYun