Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[공통] 다중 이미지 업로드 방식으로 통일 #218

Merged
merged 18 commits into from
Mar 29, 2024

Conversation

chaeseungyun
Copy link
Contributor

@chaeseungyun chaeseungyun commented Mar 28, 2024

What is this PR? 🔍

Changes 📝

메뉴 추가 및 수정에서 이미지를 다중 업로드 가능하게 수정했습니다.

ScreenShot 📷

Test CheckList ✅

  • 다중 이미지 업로드 방식으로 통일

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • Did you merge recent develop branch?

@chaeseungyun chaeseungyun self-assigned this Mar 28, 2024
Copy link
Contributor

@junghaesung79 junghaesung79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
예전에 회고할 때 다중 이미지 업로드를 구현하려고 했던 기억이 새록새록 떠오르네요~

src/utils/hooks/useImagesUpload.ts Outdated Show resolved Hide resolved
Comment on lines +50 to +56
} catch (error: any) {
setImageFile([]);
const errorMessage = error.toString();
if (errorMessage.includes('415')) {
setUploadError('415');
} else if (errorMessage.includes('404')) {
setUploadError('404');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isKoinError의 시대는 곧 온다...

@chaeseungyun chaeseungyun merged commit a26f379 into develop Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[주변상점] 구글 자동번역 방지 및 다중 파일 업로드
6 participants