feat: queryKey 파일 분리 #202
Merged
feat: queryKey 파일 분리 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/query/KeyFactory/allShopKeys.ts
Outdated
Comment on lines
1
to
3
| export const allShopKeys = { | ||
| all: ['shop'] as const, | ||
| }; |
There was a problem hiding this comment.
shopkeys.all에 이미 똑같은 키가 있는데, 얘만 왜 따로 정의하셨나요?
There was a problem hiding this comment.
해당부분 삭제 해줬습니다..! 만들어 놓고 사용하는 곳이 없었네요..겹치기도 하구요..
Comment on lines
1
to
3
| export const shopCategoryKeys = { | ||
| shopCategory: ['shopCategory'] as const, | ||
| }; |
There was a problem hiding this comment.
도메인별로 구분한다고 하면, 상점 카테고리 관련 key 들은 shopKeys 에 종속돼도 괜찮을 것 같아요
|
요것도 리마인드한번 돌릴게용 |
hanagertrudeKim
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
queryKey 파일을 분리했습니다.
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch, not themainbranchdevelopbranch?