[회원가입] 회원가입 페이지 유저 데이터 입력 로직 구현 및 api 연동 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiWonBeen
requested changes
Aug 16, 2023
HAEROOL
requested review from
hoooooony,
MinGu-Jeong,
daepan and
dooohun
as code owners
hanagertrudeKim
approved these changes
Sep 26, 2023
MinGu-Jeong
reviewed
Sep 27, 2023
MinGu-Jeong
approved these changes
Oct 23, 2023
dooohun
requested changes
Oct 24, 2023
Comment on lines
+1
to
4
| const TEMRS = [ | ||
| { | ||
| id: 'term_1', | ||
| title: '개인정보 이용약관', |
There was a problem hiding this comment.
utils/constants 상수값을 관리하는 폴더로 이동해도 괜찮을 거 같아요!
| @@ -0,0 +1,37 @@ | |||
| import { useForm } from 'react-hook-form'; | |||
|
|
|||
| const REG_EX = /^(?=.*[a-zA-Z])(?=.*[0-9])(?=.*[!@#$%^&*])[a-zA-Z0-9!@#$%^&*]{6,18}$/i; | |||
There was a problem hiding this comment.
마찬가지로 상수이므로 utils/constant에 새로 작성하는 것도 좋아 보입니다!
| { verificateError && <ErrorMessage message={verificateError} />} | ||
| {isOpen ? ( | ||
| <> | ||
| <span className={styles['email-check__alert']}>* 제한시간 5 : 00</span> |
There was a problem hiding this comment.
이메일을 보내면 제한시간이 줄어드는 기능 구현이 필요해 보입니다!
HAEROOL
added a commit
that referenced
this pull request
Nov 1, 2023
[회원가입] 회원가입 페이지 유저 데이터 입력 로직 구현 및 api 연동
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#2] request
Please check if the PR fulfills these requirements
developbranch, not themainbranchdeveopbranch?Screenshot
Precautions (main files for this PR ...)
step을 통일하기 위해progressStep과registerStep분리하여 구현했습니다.