feat: 졸업학점 계산 동의 API 및 학과, 시간표 수정 대응 #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwoo28
requested review from
Soundbar91,
seongjae6751,
daheeParkk and
duehee
duehee
approved these changes
Dec 28, 2024
| detectGraduationCalculation.updatedIsChanged(true); | ||
| }); | ||
| } | ||
| } |
Comment on lines
34
to
39
| if (student.getDepartment() == null) { | ||
| DepartmentNotFoundException.withDetail("학과를 추가하세요."); | ||
| } | ||
| if (student.getStudentNumber() == null) { | ||
| DepartmentNotFoundException.withDetail("학번을 추가하세요."); | ||
| } |
There was a problem hiding this comment.
C
예외처리 묶어서 처리하는 메소드로 관리하면 좋을 거 같아요!
Soundbar91
requested changes
Dec 28, 2024
src/main/java/in/koreatech/koin/domain/graduation/service/GraduationService.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/graduation/aop/GraduationAspect.java
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/graduation/aop/GraduationAspect.java
Outdated
Show resolved
Hide resolved
.../java/in/koreatech/koin/domain/graduation/repository/StudentCourseCalculationRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/graduation/service/GraduationService.java
Outdated
Show resolved
Hide resolved
Soundbar91
approved these changes
Dec 29, 2024
…alculator' into feature/detect-graduation # Conflicts: # src/main/java/in/koreatech/koin/domain/graduation/controller/GraduationApi.java # src/main/java/in/koreatech/koin/domain/graduation/controller/GraduationController.java # src/main/java/in/koreatech/koin/domain/graduation/repository/CatalogRepository.java # src/main/java/in/koreatech/koin/domain/graduation/service/GraduationService.java # src/main/java/in/koreatech/koin/domain/timetableV2/dto/request/TimetableLectureCreateRequest.java # src/main/java/in/koreatech/koin/domain/timetableV2/factory/TimetableLectureCreator.java # src/main/java/in/koreatech/koin/domain/timetableV2/model/TimetableLecture.java
* feat: 기능 구현 * chore: 리뷰 반영 * chore: 리뷰 반영 * chore: 리뷰 반영 * chore: 변경 여부에 따른 처리 로직 추가
…feature/detect-graduation # Conflicts: # src/main/java/in/koreatech/koin/domain/graduation/controller/GraduationController.java # src/main/java/in/koreatech/koin/domain/graduation/service/GraduationService.java # src/main/java/in/koreatech/koin/domain/timetableV2/factory/TimetableLectureCreator.java
kwoo28
merged commit 23a0b53
into
feature/1140-graduation-credit-calculator
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
졸업학점 계산 동의 API 구현했습니다.
해당 학생에 대한 졸업학점 계산 동의 요청 api를 날리게되면 계산테이블과 변경감지테이블에 학생에 대한 데이터값이 초기화됩니다.
시간표 수정
aop를 이용하여 시간표 생성, 수정, 삭제되는 요청에 대해 공통적으로 변경감지테이블의 변경 여부를 true로 변경시킵니다.
학과 수정
학생이 학과를 수정했을때 기존 계산테이블을 삭제하고, 새롭게 변경된 학과의 졸업요건에 맞게 계산테이블의 데이터값이 초기화됩니다.
💬 리뷰 중점사항