refactor: 엑셀 다운로드 따닥 방지 #1133
Merged
refactor: 엑셀 다운로드 따닥 방지 #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dradnats1012
requested review from
songsunkook,
ImTotem,
DHkimgit,
Choon0414 and
kih1015
Choon0414
approved these changes
Dec 14, 2024
| @RedisHash(value = "excelDownload") | ||
| public class ExcelDownloadCache { | ||
|
|
||
| private static final long CACHE_EXPIRE_MINUTES = 30L; |
There was a problem hiding this comment.
R
MINUTES ->SECONDS 로 수정해야 될거 같아요.
# Conflicts: # src/main/java/in/koreatech/koin/domain/coop/service/CoopService.java
kih1015
approved these changes
Dec 15, 2024
Comment on lines
7
to
8
| public class DuplicateExcelRequestException extends DuplicationException { | ||
| private static final String DEFAULT_MESSAGE = "동일한 요청을 30초 안에 다시 보낼 수 없습니다!"; |
songsunkook
approved these changes
Dec 15, 2024
| if (isCacheExist) { | ||
| throw DuplicateExcelRequestException.withDetail(startDate, endDate); | ||
| } | ||
| excelDownloadCacheRepository.save(ExcelDownloadCache.from(startDate.toString() + endDate.toString())); |
There was a problem hiding this comment.
C
startDate, endDate만 파라미터로 전달하고, 둘을 toString하여 합치는 로직은 from 안에 넣는 건 어떨까요!?
There was a problem hiding this comment.
그게 더 깔끔하고 좋을 것 같네요 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항