Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 어드민 혜택 상세 페이지 혜택문구 미리보기 추가 #1132

Merged
merged 11 commits into from
Dec 12, 2024
Merged

feat: 어드민 혜택 상세 페이지 혜택문구 미리보기 추가 #1132

merged 11 commits into from
Dec 12, 2024

Conversation

krSeonghyeon
Copy link
Contributor

🔥 연관 이슈

🚀 작업 내용

  1. 특정 혜택 카테고리 상점들의 혜택 미리보기 문구를 수정하는 api 추가
  2. 특정 혜택 카테고리 상점 추가할 때의 배열에 혜택 미리보기 문구 추가하여 요청하도록 수정
  3. 특정 혜택 카테고리 상점 조회할 때 혜택 미리보기 문구도 포함하도록 수정
  4. 관련 테스트코드 추가 및 수정

💬 리뷰 중점사항

@github-actions github-actions bot added the 기능 새로운 기능을 개발합니다. label Dec 11, 2024
@krSeonghyeon krSeonghyeon self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Unit Test Results

344 tests   343 ✔️  1m 31s ⏱️
  41 suites      1 💤
  41 files        0 ❌

Results for commit 5ca4290.

♻️ This comment has been updated with latest results.

20HyeonsuLee
20HyeonsuLee requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@20HyeonsuLee 20HyeonsuLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시험 끝나고 쉬고싶으실텐데 바로 작업하시느라 고생 많으셨습니다~ 코멘트 하나만 확인해주세요👍

src/main/java/in/koreatech/koin/admin/benefit/service/AdminBenefitService.java Outdated Show resolved Hide resolved
BaeJinho4028
BaeJinho4028 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@BaeJinho4028 BaeJinho4028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직상 크리티컬 한 부분은 없으나 몇가지만 체크해주세요 👍

src/main/java/in/koreatech/koin/admin/benefit/dto/AdminCreateBenefitShopsRequest.java Outdated Show resolved Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/dto/AdminModifyBenefitShopsRequest.java Outdated Show resolved Hide resolved
src/main/java/in/koreatech/koin/admin/benefit/repository/AdminBenefitCategoryMapRepository.java Show resolved Hide resolved
@krSeonghyeon krSeonghyeon merged commit 610fee0 into develop Dec 12, 2024
4 checks passed
@krSeonghyeon krSeonghyeon deleted the feature/1129-admin-benefit-detail branch December 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@20HyeonsuLee 20HyeonsuLee 20HyeonsuLee approved these changes

@BaeJinho4028 BaeJinho4028 BaeJinho4028 approved these changes

Assignees

@krSeonghyeon krSeonghyeon

Labels
기능 새로운 기능을 개발합니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

어드민 혜택 상세 페이지 혜택 문구 미리보기 관련 추가
3 participants
@krSeonghyeon @BaeJinho4028 @20HyeonsuLee