fix: 시간표 프레임 롤백 로직 수정 #1126
Merged
fix: 시간표 프레임 롤백 로직 수정 #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
requested review from
seongjae6751,
daheeParkk,
kwoo28 and
duehee
seongjae6751
requested changes
Dec 10, 2024
Comment on lines
108
to
115
|
|
||
| User user = userRepository.getById(userId); | ||
| List<TimetableFrame> frames = timetableFrameRepositoryV2.findAllByUserAndSemester(user, | ||
| timetableFrame.getSemester()); | ||
|
|
||
| if (frames.isEmpty()) { | ||
| timetableFrame.updateMainFlag(true); | ||
| } |
There was a problem hiding this comment.
C
존재 하는 지만 확인 하는 것이 목표라면 지금 방식보다
jpa의 exist를 사용해서 확인하는 것이 좋지 않을까 하는데 어떻게 생각하실까요?
There was a problem hiding this comment.
오오 좋은 의견주셔서 감사합니다 !
관련해서 찾아보니, exist는 데이터를 발견함과 동시에 true를 반환해서 성능 향상에도 도움을 준다고 하네요 !
반영하겠습니다 !
seongjae6751
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항