feat: 상점 혜택 상세보기 필드 추가 #1123
Merged
feat: 상점 혜택 상세보기 필드 추가 #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20HyeonsuLee
requested changes
Dec 7, 2024
| @@ -183,7 +183,8 @@ void setup() { | |||
| "is_event": false, | |||
| "is_open": true, | |||
| "average_rate": 5.0, | |||
| "review_count": 1 | |||
| "review_count": 1, | |||
| "benefit_details": ["무료"] | |||
There was a problem hiding this comment.
혜택 페이지에서는 선택한 혜택 카테고리에 맞는 설명만 나오도록 되어있습니다.
배열 대신 선택한 혜택에 해당하는 설명 하나만 반환하면 될것 같습니다. 관련된 로직도 수정해주세요!
There was a problem hiding this comment.
혜택에 해당하는 설명 하나만 반환하도록 수정하였습니다.
20HyeonsuLee
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
api는 기존에 있었고, 기능명세서대로 상점 혜택 상세보기 필드 추가하였습니다.