feature: 모든 상점 조회 API에 혜택 상세 필드 추가 #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotfix: 네이티브 쿼리 soft delete 누락 반영 (main)
develop -> main
develop -> main
develop -> main
develop -> main
develop -> main
BaeJinho4028
approved these changes
Dec 5, 2024
Comment on lines
+71
to
+73
| ShopsSortCriteria sortBy, | ||
| List<ShopsFilterCriteria> filterCriteria, | ||
| String query |
Comment on lines
+95
to
+101
| shopCaches.shopCaches(), | ||
| shopInfoMap, | ||
| sortBy, | ||
| filterCriteria, | ||
| now, | ||
| query, | ||
| benefitDetailMap |
Comment on lines
-162
to
+169
| reviewCount | ||
| reviewCount, | ||
| benefitDetails |
There was a problem hiding this comment.
여기도 뭔가 추가적인 공백이있는것같아요
Comment on lines
+1926
to
+1938
| get("/v2/shops") | ||
| .queryParam("sorter", "COUNT_DESC") | ||
| ) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(content().json(String.format(""" | ||
| { | ||
| "count": 2, | ||
| "shops": [ | ||
| { | ||
| "category_ids": [ | ||
| \s | ||
| ], | ||
| "delivery": true, |
krSeonghyeon
approved these changes
Dec 5, 2024
| @@ -10,5 +11,10 @@ public interface BenefitCategoryMapRepository extends Repository<BenefitCategory | |||
|
|
|||
| List<BenefitCategoryMap> findAllByBenefitCategoryId(Integer benefitCategoryId); | |||
|
|
|||
| @Query("SELECT bcm FROM BenefitCategoryMap bcm " + | |||
| "JOIN FETCH bcm.shop s " + | |||
| "JOIN FETCH bcm.benefitCategory bc") | |||
There was a problem hiding this comment.
멀티라인 문자열을 사용하면 더 좋을 거 같네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항