Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop -> main #1118

Merged
merged 14 commits into from
Dec 4, 2024
Merged

develop -> main #1118

merged 14 commits into from
Dec 4, 2024

Conversation

Soundbar91
Copy link
Contributor

πŸ”₯ μ—°κ΄€ 이슈

  • close #이슈번호

πŸš€ μž‘μ—… λ‚΄μš©

πŸ’¬ 리뷰 쀑점사항

Soundbar91 and others added 14 commits November 27, 2024 14:15
* chore: classPlace 크기 λ³€κ²½

* chore: κ°•μ˜ μž₯μ†Œ 리슀트둜 μž…λ ₯받도둝 λ³€κ²½

* test: ν…ŒμŠ€νŠΈ μ½”λ“œ μˆ˜μ •

* chore: 좩돌 검사

* fix: 좩돌 ν•΄κ²°

* fix: timetableLecture 생성 및 μˆ˜μ • dto μˆ˜μ •

* fix: class_place μžλ£Œν˜• λ³€κ²½

* test: ν…ŒμŠ€νŠΈ μˆ˜μ •

* test: ν…ŒμŠ€νŠΈ μˆ˜μ •

* chore: classPlace 크기 μœ νš¨μ„± 검증 λ³€κ²½

* chore: class_time 생성 둜직 λ³€κ²½

* chore: λ―Έμ‚¬μš© import 제거

* fix: NPE ν•΄κ²°

* chore: μ™œ 이거 λΉ μ Έμžˆμ§€

* μž„μ‹œ 컀밋

* fix: 응닡 dto ν˜•μ‹ λ³€κ²½

* fix: κ°•μ˜ μž₯μ†Œ 곡백 μ‚­μ œ

* test: 응닡 dto μˆ˜μ •μœΌλ‘œ μΈν•œ ν…ŒμŠ€νŠΈ μˆ˜μ •

* chore: 주석 μΆ”κ°€ 및 λ³€μˆ˜λͺ… λ³€κ²½

* chore: 리뷰 반영
* feat: μœ„ν—˜ν•œ sqlλ¬Έ 체크 둜직 μΆ”κ°€

* chore: 넀이밍 λ³€κ²½
* fix: 인덱슀 μ—λŸ¬ μˆ˜μ •

* fix: 인덱슀 μ—λŸ¬ μˆ˜μ •

* fix: μ •κ·œ κ°•μ˜ λΆ„ν•  λ°˜ν™˜

* fix: λ‘€λ°±

* test: ν…ŒμŠ€νŠΈ μˆ˜μ •

* fix: 둜직 μˆ˜μ •

* fix: λ‘€λ°±

* fix: deleteTimetableLectures 검증 였λ₯˜ μˆ˜μ •

* fix: κ°•μ˜ μž₯μ†Œκ°€ μ—†λŠ” κ°•μ˜ 정보가 λ‘κ°œ 이상 듀어왔을 λ•Œ 였λ₯˜ ν•΄κ²°

* fix: 빈 λ¬Έμžμ—΄ μ—λŸ¬ μˆ˜μ •

* chore: μŠ€μ›¨κ±° μ„€λͺ… μˆ˜μ •

* chore: todo μž‘μ„±

* fix: class_place "null" μ €μž₯ μˆ˜μ •

* chore: λ―Έμ‚¬μš© import μ‚­μ œ
* fix : μ •μ νŒŒμΌμ²˜λ¦¬ μΆ”κ°€

* chore : ν•„μš”μ—†λŠ” 주석 μ‚­μ œ
* feat: lecture μžλ£Œν˜• 컬럼 μ‚¬μ΄μ¦ˆ λ³€κ²½ flyway μΆ”κ°€

* feat: lecture ν…Œμ΄λΈ”μ— semester fk μΆ”κ°€

* feat: semester_date μ‚­μ œ

* test: ν…ŒμŠ€νŠΈ μ½”λ“œ μˆ˜μ •

* test: ν…ŒμŠ€νŠΈ μ½”λ“œ μˆ˜μ •

* chore: semester둜 μˆ˜μ •

* test: ν…ŒμŠ€νŠΈ μ½”λ“œ μˆ˜μ •

* chore: 리뷰 반영

* fix: 좩돌 ν•΄κ²°

* chore: μƒμ„±μž μ ‘κ·Ό μ œμ–΄μž λ³€κ²½

* fix: flyway μˆ˜μ •

* fix: flyway μˆ˜μ •

* fix: flyway μˆ˜μ •

* fix: flyway μˆ˜μ •

* fix: Lecture entity μˆ˜μ •

* test: ν…ŒμŠ€νŠΈ μ½”λ“œ μˆ˜μ •
* fix: NPE λ°œμƒ λΆ€λΆ„ μž„μ‹œ 쑰치

* feat: accessHistoryId 토큰 λ°œκΈ‰ API μΆ”κ°€ 및 일뢀 λ¦¬νŒ©ν† λ§
* fix: 6μ‹œ 이후 μ‹œκ°„μ€ μ‹œκ°„ν‘œμ—μ„œ μ œμ™Έν•˜κ³  μ‘°νšŒλ˜λ„λ‘ μˆ˜μ •

* refactor: else 제거

* refactor: isValidClassTime()의 ifλ¬Έ κ°œμ„ 

---------

Co-authored-by: daheePark <[email protected]>
* feat: μ‚­μ œλœ μ‹œκ°„ν‘œ κ°•μ˜ 볡ꡬ 둜직

* feat: μ‚­μ œλœ μ‹œκ°„ν‘œ κ°•μ˜ 볡ꡬ ν…ŒμŠ€νŠΈ

* feat: μ‚­μ œλœ μ‹œκ°„ν‘œ ν”„λ ˆμž„ κ°•μ˜ 볡ꡬ

* feat: μ‚­μ œλœ μ‹œκ°„ν‘œ ν”„λ ˆμž„ κ°•μ˜ 볡ꡬ ν…ŒμŠ€νŠΈ

* fix: TimetableApiV2 μ–΄λ…Έν…Œμ΄μ…˜ μˆ˜μ •

* fix: ν…ŒμŠ€νŠΈ μˆ˜μ • 및 둜직 μˆ˜μ •

* fix: μ‹œκ°„ν‘œ μ†Œν”„νŠΈ λ”œλ¦¬νŠΈλ‘œ λ³€κ²½

* fix: λΆˆν•„μš”ν•œ import 제거

* fix: repository λ©”μ„œλ“œλͺ… μˆ˜μ •

* fix: ν…ŒμŠ€νŠΈ μˆ˜μ • 및 μ‚­μ œ 둜직 μˆ˜μ •

* fix: 곡백 μˆ˜μ •

* fix: λ‘€λ°± 둜직 μˆ˜μ •

* fix: apiμ„€λͺ… μˆ˜μ •

* fix: timetable μ†Œν”„νŠΈλ”œλ¦¬νŠΈ λ³€κ²½

---------

Co-authored-by: 김원경 <[email protected]>
* feat: μ‹œκ°„ν‘œ ν”„λ ˆμž„ ν•œλ²ˆμ— λ‹€ 쑰회 κΈ°λŠ₯ κ΅¬ν˜„

* test: ν…ŒμŠ€νŠΈ κ΅¬ν˜„

* chore: 리뷰반영

* chore: dto둜 λ³€ν™˜
* fix: flyway μ‚­μ œ

* fix: 연관관계 μ‚­μ œ

* test: ν…ŒμŠ€νŠΈ μˆ˜μ •

* test: λ―Έμ‚¬μš© import μ‚­μ œ
* fix: TimetableLectureUpdateRequest Listν•„λ“œ 검증 μ–΄λ…Έν…Œμ΄μ…˜ μΆ”κ°€

* fix: Integer id 검증 μΆ”κ°€ 및 둜직 μˆ˜μ •

---------

Co-authored-by: 김원경 <[email protected]>
Copy link
Contributor

@duehee duehee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™”μ΄νŒ…!

Copy link

github-actions bot commented Dec 4, 2024

Unit Test Results

342 tests   341 βœ”οΈβ€ƒβ€ƒ1m 28s ⏱️
βŸβ€„41 suitesβ€ƒβ€ƒβŸβ€„βŸβ€„1 πŸ’€
βŸβ€„41 filesβ€„β€‚β€ƒβ€ƒβŸβ€„βŸβ€„0 ❌

Results for commit f9a8828.

@Soundbar91 Soundbar91 merged commit b1af75d into main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants