Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PUT/v2/timetables/lecture 검증 로직 추가 #1117

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: PUT/v2/timetables/lecture 검증 로직 추가 #1117

merged 2 commits into from
Dec 4, 2024

Conversation

kwoo28
Copy link
Contributor

@kwoo28 kwoo28 commented Dec 4, 2024 •
edited
Loading

🔥 연관 이슈

🚀 작업 내용

  1. Integer id에 notnull추가했습니다.

@kwoo28 kwoo28 self-assigned this Dec 4, 2024
@github-actions github-actions bot added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Unit Test Results

342 tests   341 ✔️  1m 23s ⏱️
  41 suites      1 💤
  41 files        0 ❌

Results for commit e2a593e.

♻️ This comment has been updated with latest results.

Soundbar91
Soundbar91 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Soundbar91 Soundbar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대응해주셔서 감사합니다(__)

...ain/java/in/koreatech/koin/domain/timetableV2/dto/request/TimetableLectureUpdateRequest.java
@@ -20,13 +21,14 @@ public record TimetableLectureUpdateRequest(
Integer timetableFrameId,

@Valid
@NotEmpty(message = "시간표 정보를 입력해주세요.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

Empty 먹히나용 ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 ㅋㅋ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿이에요

duehee
duehee approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@duehee duehee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 :D

...ain/java/in/koreatech/koin/domain/timetableV2/dto/request/TimetableLectureUpdateRequest.java
@@ -20,13 +21,14 @@ public record TimetableLectureUpdateRequest(
Integer timetableFrameId,

@Valid
@NotEmpty(message = "시간표 정보를 입력해주세요.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿이에요

@kwoo28 kwoo28 merged commit f9a8828 into develop Dec 4, 2024
4 checks passed
@kwoo28 kwoo28 deleted the fix/1116-timetableLectureUpdateRequest branch December 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duehee duehee duehee approved these changes

@seongjae6751 seongjae6751 seongjae6751 approved these changes

@Soundbar91 Soundbar91 Soundbar91 approved these changes

@daheeParkk daheeParkk Awaiting requested review from daheeParkk

Assignees

@kwoo28 kwoo28

Labels
버그 정상적으로 동작하지 않는 문제상황입니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

시간표 수정 dto 리스트 필드 검증
4 participants
@kwoo28 @Soundbar91 @seongjae6751 @duehee