feat: 시간표 프레임 한번에 조회 구현 #1108
Merged
feat: 시간표 프레임 한번에 조회 구현 #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
requested changes
Dec 2, 2024
| @@ -77,7 +77,7 @@ ResponseEntity<TimetableFrameUpdateResponse> updateTimetableFrame( | |||
| @Operation(summary = "시간표 프레임 조회") | |||
| @SecurityRequirement(name = "Jwt Authentication") | |||
| @GetMapping("/v2/timetables/frame") | |||
There was a problem hiding this comment.
R
이거 왜 인지 모르겠는데, 컨트롤러랑 API Path가 다르네요..? 뭐지뭐지
There was a problem hiding this comment.
이미 클라에서 적용이 됐을 것 같은데 /v2/timetables/frame은 기존 방식, /v2/timetables/frames는 새로운 방식으로 나눠도 좋을 것 같아요. 대응이 필요한,,
There was a problem hiding this comment.
스웨거에는 기존꺼도 /v2/timetables/frames로 올라가있네요!
저는 그래서 그냥 지금처럼 해도 되지 않을까 하는데 어떻게 생각하시나요
| @@ -77,7 +77,7 @@ ResponseEntity<TimetableFrameUpdateResponse> updateTimetableFrame( | |||
| @Operation(summary = "시간표 프레임 조회") | |||
| @SecurityRequirement(name = "Jwt Authentication") | |||
| @GetMapping("/v2/timetables/frame") | |||
| ResponseEntity<List<TimetableFrameResponse>> getTimetablesFrame( | |||
| ResponseEntity<Object> getTimetablesFrame( | |||
| @RequestParam(name = "semester") String semester, | |||
There was a problem hiding this comment.
C
여기에도 required 옵션 줘야 하나용 ??
| Semester semester = semesterRepositoryV2.getBySemester(semesterRequest); | ||
| return timetableFrameRepositoryV2.findAllByUserIdAndSemesterId(userId, semester.getId()).stream() | ||
| .map(TimetableFrameResponse::from) | ||
| .toList(); | ||
| } | ||
|
|
||
| @Transactional(readOnly = true) |
There was a problem hiding this comment.
C
클래스에 readOnly 트랜잭션이 걸려있는데, 여기에 추가하신 이유가 궁금합니다 !
| Collectors.mapping(TimetableFrameResponse::from, Collectors.toList()) | ||
| )); | ||
|
|
||
| return Map.of("semesters", groupedBySemester); |
There was a problem hiding this comment.
C
dto 클래스로 반환할 수 있을 것 같아요.
리펙토링 할 때 반영하면 좋을 것 같아요 !
There was a problem hiding this comment.
그냥 생각없이 만들어서 바로 올리고 씻으면서 dto로 변환해야겠다 바로 생각이 들었었습니다..ㅎㅎ
짚어주셔서 감사합니당 수정하겠습니다!
Soundbar91
approved these changes
Dec 2, 2024
kwoo28
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
requestparam인 semester가 없을때는 아래와 같은 값을 반환하게 했습니다.
{ "semesters": { "20242": [ { "id": 1, "timetable_name": "시간표1", "is_main": false }, { "id": 2, "timetable_name": "시간표2", "is_main": true }, { "id": 3, "timetable_name": "시간표3", "is_main": false } ], "20241": [ { "id": 4, "timetable_name": "시간표1", "is_main": false }, { "id": 5, "timetable_name": "시간표2", "is_main": true }, { "id": 6, "timetable_name": "시간표3", "is_main": false } ] } }💬 리뷰 중점사항