Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shop softDelete시에 reviews도 softDelete 되도록 수정 #1098

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

krSeonghyeon
Copy link
Contributor

🔥 연관 이슈

🚀 작업 내용

  1. shop softDelete시에 해당 shop과 관련된 review들도 softdelete 되도록 변경하였습니다.
  2. 삭제된 상점 복구시에 해당 shop과 관련된 review들도 복구되도록 변경하였습니다.

💬 리뷰 중점사항

  • 간단한 변경입니다

@github-actions github-actions bot added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Nov 28, 2024
@krSeonghyeon krSeonghyeon changed the title fix: shop softDelete시에 reviews도 softdelete 되도록 수정 fix: shop softDelete시에 reviews도 softDelete 되도록 수정 Nov 28, 2024
Copy link
Contributor

@Soundbar91 Soundbar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Unit Test Results

339 tests   338 ✔️  1m 20s ⏱️
  41 suites      1 💤
  41 files        0

Results for commit 02db99a.

@krSeonghyeon krSeonghyeon merged commit aaa47ae into develop Nov 28, 2024
5 checks passed
@krSeonghyeon krSeonghyeon deleted the fix/1097-shop-delete-reviews branch November 28, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
버그 정상적으로 동작하지 않는 문제상황입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

상점 softdelete시 리뷰가 삭제되지 않는 버그 수정
3 participants