fix: abtest 데드락 발생 최소화 #1092
Merged
fix: abtest 데드락 발생 최소화 #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songsunkook
requested review from
ImTotem,
Choi-JJunho,
DHkimgit,
seongjae6751,
dradnats1012,
20HyeonsuLee,
Choon0414 and
kih1015
ImTotem
approved these changes
Nov 26, 2024
dradnats1012
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
데드락(access_history 업데이트) 발생 가능성 최소화를 위해 중요도가 떨어지는 로직을 제거했습니다.
마지막 접속 시각 업데이트 로직을 제거했는데, 이 로직은 원래부터 여기가 아니라 로그인/리프레시 요청에 삽입하려고 설계했기에 급한대로 로직 제거만 선행했습니다. 각 로그인 요청에 적용하고 클라이언트에 요청하는 것은 추후 진행하겠습니다.
이 PR이 실제 환경에 미치는 영향은 "어드민페이지에서 AB테스트 실험군 수동 편입 시 기기 정보에 나타나는 마지막 접속 일시가 업데이트되지 않는다" 정도이기에 문제 해결을 먼저 진행하고자 합니다.
💬 리뷰 중점사항