Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abtest 데드락 발생 최소화 #1091

Closed
wants to merge 5 commits into from
Closed

fix: abtest 데드락 발생 최소화 #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
454b660
Merge pull request #967 from BCSDLab/hotfix/search-author-null
songsunkook Oct 17, 2024
26c0d73
Merge pull request #972 from BCSDLab/develop
Choon0414 Oct 18, 2024
06ffdf1
Merge pull request #1003 from BCSDLab/develop
BaeJinho4028 Nov 7, 2024
6fa6a3f
Merge pull request #1046 from BCSDLab/develop
seongjae6751 Nov 18, 2024
36dd417
remove: 실험군 조회 시 마지막 접속 시각 업데이트 로직 제거
songsunkook Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/in/koreatech/koin/admin/abtest/model/AccessHistory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ public void removeVariable(AbtestVariable variable) {
);
}

// TODO: 각 로그인 및 리프레시 요청에 추가 필요
public void updateLastAccessedAt(Clock clock) {
this.lastAccessedAt = LocalDateTime.now(clock);
}
Expand Down
4 changes: 0 additions & 4 deletions src/main/java/in/koreatech/koin/admin/abtest/service/AbtestService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package in.koreatech.koin.admin.abtest.service;

import java.time.Clock;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
Expand Down Expand Up @@ -51,7 +50,6 @@
@Transactional(readOnly = true)
public class AbtestService {

private final Clock clock;
private final EntityManager entityManager;
private final AbtestVariableCountRepository abtestVariableCountRepository;
private final AbtestRepository abtestRepository;
Expand Down Expand Up @@ -161,7 +159,6 @@ public AbtestAssignResponse assignOrGetVariable(Integer accessHistoryId, UserAge
accessHistory.addAbtestVariable(variable);
countCacheUpdate(variable);
variableAssignCacheSave(variable, accessHistory.getId());
accessHistory.updateLastAccessedAt(clock);
return AbtestAssignResponse.of(variable, accessHistory);
}

Expand Down Expand Up @@ -217,7 +214,6 @@ private AbtestVariable getMyVariable(Integer accessHistoryId, UserAgentInfo user
abtestVariableAssignRepository.save(AbtestVariableAssign.of(dbVariable.getId(), accessHistory.getId()));
return dbVariable;
}
accessHistory.updateLastAccessedAt(clock);
return cacheVariable.get();
}

Expand Down
Loading