Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 어드민 유저 리팩토링 #1083

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Conversation

kwoo28
Copy link
Contributor

@kwoo28 kwoo28 commented Nov 25, 2024

🔥 연관 이슈

🚀 작업 내용

  1. 유저패키지를 유저, 사장, 학생 패키지로 나눴습니다.

  2. 유저패키지에 검증 클래스를 두었습니다.

  3. 읽기 힘든 로직을 개선했습니다.

💬 리뷰 중점사항

@github-actions github-actions bot added the 리팩터링 리팩터링을 위한 이슈입니다 label Nov 25, 2024
Copy link
Contributor

@Soundbar91 Soundbar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다,,

충돌이 쉽지 않은 거였네요.. 이렇게 또 배워갑니다 ㅠㅠ,,,

@ParameterObject @ModelAttribute OwnersCondition ownersCondition,
@Auth(permit = {ADMIN}) Integer adminId
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link

github-actions bot commented Nov 25, 2024

Unit Test Results

340 tests   339 ✔️  1m 29s ⏱️
  39 suites      1 💤
  39 files        0

Results for commit 8aaf75a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@duehee duehee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요~ 제가 늦었네용 ㅎ..

@kwoo28 kwoo28 merged commit c2fcee0 into develop Nov 25, 2024
3 checks passed
@kwoo28 kwoo28 deleted the refactor/1080-admin-user branch November 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
리팩터링 리팩터링을 위한 이슈입니다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: 어드민 유저 리팩토링
4 participants