Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abtest 데드락 이슈 발견/해결 #1075

Closed
wants to merge 2 commits into from
Closed

fix: abtest 데드락 이슈 발견/해결 #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
914d68d
refactor: 불필요하게 메소드화 되어있는 로직 풀어헤치기
Choi-JJunho Nov 24, 2024
902ad6c
refactor: 비즈니스로직 정렬
Choi-JJunho Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/in/koreatech/koin/admin/abtest/controller/AbtestApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ ResponseEntity<Void> assignAbtestVariableByAdmin(
@Operation(summary = "(NORMAL) 실험군 편입 정보 확인")
@PostMapping("/assign")
ResponseEntity<AbtestAssignResponse> assignOrGetAbtestVariable(
@RequestHeader("accessHistoryId") Integer accessHistoryId,
@RequestHeader("access_history_id") Integer accessHistoryId,
@UserAgent UserAgentInfo userAgentInfo,
@UserId Integer userId,
@RequestBody @Valid AbtestAssignRequest abtestAssignRequest
Expand Down
8 changes: 5 additions & 3 deletions ...itory/AbtestVariableAssignRepository.java → .../AbtestVariableAssignRedisRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,18 @@

import in.koreatech.koin.admin.abtest.model.redis.AbtestVariableAssign;

public interface AbtestVariableAssignRepository extends Repository<AbtestVariableAssign, String> {
public interface AbtestVariableAssignRedisRepository extends Repository<AbtestVariableAssign, String> {

AbtestVariableAssign save(AbtestVariableAssign abtestVariableAssign);

Optional<AbtestVariableAssign> findById(String id);

void deleteById(String id);

default Optional<AbtestVariableAssign> findByVariableIdAndAccessHistoryId(Integer variableId,
Integer accessHistoryId) {
default Optional<AbtestVariableAssign> findByVariableIdAndAccessHistoryId(
Integer variableId,
Integer accessHistoryId
) {
return findById(variableId + DELIMITER + accessHistoryId);
}

Expand Down
2 changes: 1 addition & 1 deletion ...sitory/AbtestVariableCountRepository.java → ...y/AbtestVariableCountRedisRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import in.koreatech.koin.admin.abtest.model.redis.AbtestVariableCount;

public interface AbtestVariableCountRepository extends CrudRepository<AbtestVariableCount, Integer> {
public interface AbtestVariableCountRedisRepository extends CrudRepository<AbtestVariableCount, Integer> {

List<AbtestVariableCount> findAll();

Expand Down
3 changes: 3 additions & 0 deletions src/main/java/in/koreatech/koin/admin/abtest/repository/AbtestVariableRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package in.koreatech.koin.admin.abtest.repository;

import java.util.List;
import java.util.Optional;

import org.springframework.data.repository.Repository;
Expand All @@ -11,6 +12,8 @@ public interface AbtestVariableRepository extends Repository<AbtestVariable, Int

Optional<AbtestVariable> findById(Integer variableId);

List<AbtestVariable> findAllByIdIn(List<Integer> ids);

default AbtestVariable getById(Integer variableId) {
return findById(variableId).orElseThrow(() ->
AbtestVariableNotFoundException.withDetail("AbtestVariable id: " + variableId));
Expand Down
Loading
Loading