refactor: 엑셀 메서드 분리 #1041
Merged
refactor: 엑셀 메서드 분리 #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dradnats1012
requested review from
Choon0414,
songsunkook,
kih1015,
ImTotem and
DHkimgit
and removed request for
songsunkook
DHkimgit
approved these changes
Nov 26, 2024
Comment on lines
137
to
142
| LocalDate limitDate = LocalDate.of(2022, 11, 29); | ||
| LocalDate today = LocalDate.now(); | ||
|
|
||
| if (startDate.isBefore(limitDate) || endDate.isBefore(limitDate)) { | ||
| throw new DiningLimitDateException("2022/11/29 식단부터 다운받을 수 있어요."); | ||
| } |
Choon0414
approved these changes
Dec 3, 2024
| } | ||
|
|
||
| private void addHeaderRow(Sheet sheet, CellStyle headerStyle) { | ||
| String[] headers = {"날짜", "타입", "코너", "칼로", "메뉴", "이미지", "품절 여부", "변경 여부"}; |
| }); | ||
|
|
||
| for (int i = 0; i < EXCEL_COLUMN_COUNT; i++) { | ||
| for (int i = 0; i < 8; i++) { |
| if (startDate.isAfter(endDate)) { | ||
| throw new StartDateAfterEndDateException("시작일은 종료일 이전으로 설정해주세요."); | ||
| throw new StartDateAfterEndDateException("시작일은 종료일 이전으로 설정해주세요"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
동시성 제어 어노테이션을 적용하려고 했는데 이상하게도 적용이 되지 않는 상황을 발견해서 해당 문제는 일단 보류하겠습니다.