Skip to content

Commit

Permalink
remove: 실험군 조회 시 마지막 접속 시각 업데이트 로직 제거
Browse files Browse the repository at this point in the history
  • Loading branch information
songsunkook committed Nov 26, 2024
1 parent 6fa6a3f commit 36dd417
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ public void removeVariable(AbtestVariable variable) {
);
}

// TODO: 각 로그인 및 리프레시 요청에 추가 필요
public void updateLastAccessedAt(Clock clock) {
this.lastAccessedAt = LocalDateTime.now(clock);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package in.koreatech.koin.admin.abtest.service;

import java.time.Clock;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
Expand Down Expand Up @@ -51,7 +50,6 @@
@Transactional(readOnly = true)
public class AbtestService {

private final Clock clock;
private final EntityManager entityManager;
private final AbtestVariableCountRepository abtestVariableCountRepository;
private final AbtestRepository abtestRepository;
Expand Down Expand Up @@ -161,7 +159,6 @@ public AbtestAssignResponse assignOrGetVariable(Integer accessHistoryId, UserAge
accessHistory.addAbtestVariable(variable);
countCacheUpdate(variable);
variableAssignCacheSave(variable, accessHistory.getId());
accessHistory.updateLastAccessedAt(clock);
return AbtestAssignResponse.of(variable, accessHistory);
}

Expand Down Expand Up @@ -217,7 +214,6 @@ private AbtestVariable getMyVariable(Integer accessHistoryId, UserAgentInfo user
abtestVariableAssignRepository.save(AbtestVariableAssign.of(dbVariable.getId(), accessHistory.getId()));
return dbVariable;
}
accessHistory.updateLastAccessedAt(clock);
return cacheVariable.get();
}

Expand Down

0 comments on commit 36dd417

Please sign in to comment.