feat: 시간표 POST, PUT 예시 #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: presigned url 에만 https 프로토콜 적용되도록 수정
daheeParkk
approved these changes
Mar 30, 2024
Comment on lines
52
to
79
| @ApiOperation(value = "", authorizations = {@Authorization(value="Authorization")}) | ||
| @RequestMapping(value = "/timetables", method = RequestMethod.POST) | ||
| public @ResponseBody | ||
| ResponseEntity createTimeTables(@ApiParam(value = "json value (예시: {\"timetable\":[...], \"semester\":\"20191\"}" + | ||
| " Timetable REQUIRED class_time, class_title, grades", required = true) @RequestBody String timetable_log) throws Exception { | ||
| ResponseEntity createTimeTables(@ApiParam(value = "json value (예시:\n" + | ||
| "{\n" + | ||
| " \"timetable\": [\n" + | ||
| " {\n" + | ||
| " \"code\": \"CPC490\",\n" + | ||
| " \"class_title\": null,\n" + | ||
| " \"class_time\": [\n" + | ||
| " 210,\n" + | ||
| " 211\n" + | ||
| " ],\n" + | ||
| " \"class_place\": null,\n" + | ||
| " \"professor\": null,\n" + | ||
| " \"grades\": null,\n" + | ||
| " \"lecture_class\": \"01\",\n" + | ||
| " \"target\": \"디자 1 건축\",\n" + | ||
| " \"regular_number\": \"25\",\n" + | ||
| " \"design_score\": \"0\",\n" + | ||
| " \"department\": \"디자인ㆍ건축공학부\",\n" + | ||
| " \"memo\": null\n" + | ||
| " }\n" + | ||
| " ],\n" + | ||
| " \"semester\": \"20192\"\n" + | ||
| "}", required = true) @RequestBody String timetable_log) throws Exception { | ||
| return new ResponseEntity<Map<String, Object>>(timeTableService.createTimeTables(timetable_log), HttpStatus.CREATED); | ||
| } |
There was a problem hiding this comment.
C
코드 보기가 너무 안 좋은데 timetable_log를 DTO로 바꿔서 그 안에 넣는건 어려울까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
▶ Request
Content
Timetables API의 POST, PUT 입력 JSON예시를 추가하였습니다.
✅ Check List
pom.xml) 변경이 일어나지 않았는지📸 API Document ScreenShot
🧪 Test