Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[공통] 이미지경로 수정, favicon, title 추가 #7

Merged
merged 6 commits into from
Feb 11, 2024
Merged

[공통] 이미지경로 수정, favicon, title 추가 #7

merged 6 commits into from
Feb 11, 2024

Conversation

MinGu-Jeong
Copy link
Collaborator

[#5 ] request

  • 이미지경로를 /public/~ 으로 수정하여 빌드과정에서 이미지를 사용할 수 있도록 하였습니다.
  • favicon을 추가하였습니다.
  • title을 BCSD Internal로 수정했습니다.

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • Did you merge recent develop branch?

Screenshot

스크린샷 2024-02-10 오후 9 38 27

Precautions (main files for this PR ...)

Close #5

@MinGu-Jeong MinGu-Jeong added the bug Something isn't working label Feb 10, 2024
@MinGu-Jeong MinGu-Jeong self-assigned this Feb 10, 2024
@ChoiWonBeen
Copy link
Member

이미지를 서버에 업로드해 쓰는건 어땠을까요~?

@MinGu-Jeong
Copy link
Collaborator Author

이미지를 서버에 올려 사용하도록 수정했습니다. 8bc509e

@MinGu-Jeong MinGu-Jeong merged commit 34e12bd into main Feb 11, 2024
1 check passed
@MinGu-Jeong MinGu-Jeong deleted the feature/#5 branch February 11, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChoiWonBeen ChoiWonBeen ChoiWonBeen approved these changes

@dooohun dooohun Awaiting requested review from dooohun dooohun is a code owner

@chaeseungyun chaeseungyun Awaiting requested review from chaeseungyun chaeseungyun is a code owner

@hanagertrudeKim hanagertrudeKim Awaiting requested review from hanagertrudeKim hanagertrudeKim is a code owner

Assignees

@MinGu-Jeong MinGu-Jeong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

이미지경로 수정, favicon, title 추가
2 participants
@MinGu-Jeong @ChoiWonBeen