Fix multiplication sign #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lotes
force-pushed
the
lotes/188-multiplicator-sign
branch
from
e3db9ab
to
be4b328
Compare
|
Turning lexer to parser rule unfortunately allows to write LabelRefs with a hidden token between asterisk and label name : We need to fix or at least validate this case. |
Fix the bug Add more escaped ids Added validation for symbolic label reference text #188 Rebased on master
dhuebner
force-pushed
the
lotes/188-multiplicator-sign
branch
from
af99ac3
to
447b1d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
The problem was that
*ABCinXYZ*ABCwas interpreted as symbolic label name. By removing the token and lifting it up to a data parser rule, it is possible to interpret it as multiplication.