Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue when multiplication sign * is not surrounded by whitespace #188

Closed
StephanWald opened this issue Nov 2, 2024 · 1 comment · Fixed by #203
Closed

issue when multiplication sign * is not surrounded by whitespace #188

StephanWald opened this issue Nov 2, 2024 · 1 comment · Fixed by #203
Labels
common pattern

Comments

@StephanWald
Copy link
Member

This is flagged as error, but whitespace is optional around mathematical operators:

imageW = int(p_width + (2*p_hPadding))
imageH = int(p_height + (2*p_vPadding))
@Lotes
Copy link
Collaborator

Lotes commented Nov 26, 2024

@dhuebner The problem here is the symbolic label name:

terminal SYMBOLIC_LABEL_NAME: /\*[a-zA-Z]+?/;

I think *p_hPadding is interpreted as a token instead of a multiplication sign and operand.
I am not sure what we can do here. Maybe split the terminal and validate whether it is a symbolic label name or not. WDYT?

@Lotes Lotes mentioned this issue Nov 26, 2024
Merged
dhuebner added a commit that referenced this issue Dec 5, 2024
@dhuebner
Added validation for symbolic label reference text #188
af99ac3
dhuebner pushed a commit that referenced this issue Dec 5, 2024
@Lotes @dhuebner
Conflicting SymbolicLabelRef and multiplication #188
447b1d0 
Fix the bug

Add more escaped ids

Added validation for symbolic label reference text #188

Rebased on master
dhuebner pushed a commit that referenced this issue Dec 5, 2024
@Lotes @dhuebner
Conflicting SymbolicLabelRef and multiplication #188
5f4cf23 
Fix the bug

Add more escaped ids

Added validation for symbolic label reference text #188

Rebased on master
@dhuebner dhuebner mentioned this issue Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
common pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix multiplication sign BBx-Kitchen/bbj-language-server
2 participants
@Lotes @StephanWald