Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pull request to address matthewholman#106 , adding support for the spice kernel version of DE440.
Overview of Changes
assist_spk_calc_planets
functions for the planets when the spk planets file is detected, otherwise using the existingassist_jpl_calc
.assist_spk_calc_planets
differs fromassist_spk_calc
mainly in that it calculates velocity and acceleration. It also maps the assist planet indices to their spk target codes, rather than directly using an index.assist_get_constant
function that will conditionally get the constant from whichever of the two files the data was initialized from.truncate_double
function, to truncate the significand. This is explained in "Differences in Coefficient Values between ASCII and SPICE", below.Verification
I have added unit tests for initializing the spk files, loading the constant data, and joining masses to the targets from the loaded constant data.
I have also added a couple of identical unit tests for Apophis and Ceres to make sure tolerances were kept between the two implementations. I manually checked most of the other unit tests as well, but didn't want to duplicate each one until I received opinions on how to structure the unit tests. I could update them all to be parameterized from command line arguments if that seems better.
Earth & Moon Residuals
There is still a disagreement on order 1e-15 AU for the Earth and Moon ephemeris. This difference causes the SPICE and ASCII implementations to perform differently. In particular with the Apophis unit test, the SPICE implementation has a delta from JPL small body of ~47m, whereas the ASCII implementation is ~93m.
The ASCII file contains data for Moon (Earth geocenter frame) and EMB (SSB frame). The SPICE file contains data for Moon (EMB frame), Earth (EMB frame) and EMB (SSB frame). As far as I can tell, this means I cannot use an identical implementation, as the lunar frames are different. For the SPICE implementation, I believe I should be able to simply add the vectors (e.g.
Moon (SSB) = EMB (SSB) + Moon (EMB)
).I have verified that the following values are identical and not the source of the disagreement:
I'd love suggestions on how to get these number into total agreement. In the case of the ASCII file, Is it possible that using the Earth-Moon mass ratio to calculate the Moon (SSB) and Earth (SSB) vectors is not as accurate?
Differences in Coefficient Values between ASCII and SPICE
This is a bit of a separate topic, and potentially a big one. After a lot of digging, I believe that there is a difference in the double values loaded directly from the files into the memory maps. These differences are quite small and likely below the usable precision of the coefficients. However, the residuals are enough to affect the results.
Here is a table of coefficients for the Sun at J2000. The left column is the value extracted from the plaintext readable ASCII version. The middle column is the residual of the binary to its ASCII version (they are identical, as expected). The right column is the residual of the SPICE kernel to the ASCII file.
I wanted to make sure that the disagreement didn't have to do with the way that ASSIST was memory mapping the files. I used Brandon Rhode's
jplephem
to separately load the coefficient values from the SPICE file and it is reading them identically to the ASSIST implementation.Precision
You may notice that the residuals are proportional the value itself. This could be explained by one or two units of precision difference for the float significand in the two files. I couldn't locate how precise they ought to be (e.g., are the real values using the full precision offered by the double). Perhaps someone more familiar with the specification knows.
Amelioration
I was able to get identical behavior from both implementations by using a
truncate_double
function. This function masks the bits to a desired precision of the float significand. After manually exploring different levels of truncation, I found that masking down to 40 bits eliminated the difference between the coefficient values. Interestingly, adding this truncation also appears to put the unit tests in closer agreement with the JPL Small Body Code, at least for the Apophis and Ceres unit tests. Truncating further causes them to agree less with JPL Small Body Code, as one might expect.While the truncation offers a solution for agreement between SPICE and ASCII, I am concerned and curious about why it makes them agree more with Horizons and Small Body. Does this imply that small body, for example, are using truncated or different values than are located in the spice kernels? I don't know, but I want to find out.