Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Remove KeyVault Dependency and Initialize clients using Managed identity directly. Also, update BlobTriggerFunction to read blobstream and do document analysis on read chunks. #2

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

amisi01
Copy link
Contributor

@amisi01 amisi01 commented Aug 22, 2024

Remove KeyVault Dependency and Initialize clients using Managed identity directly. Also, update BlobTriggerFunction to read blobstream and do document analysis on read chunks.

@amisi01 amisi01 requested a review from Pilchie August 22, 2024 21:25
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
deployment/cosmosdb.bicepparam Outdated Show resolved Hide resolved
deployment/functionapp.bicep Outdated Show resolved Hide resolved
deployment/functionapp.bicep Outdated Show resolved Hide resolved
deployment/functionapp.bicep Show resolved Hide resolved
deployment/functionapp.bicep Outdated Show resolved Hide resolved
@amisi01 amisi01 force-pushed the users/amisi/useridentitychanges branch from f636a3a to 242bb42 Compare August 22, 2024 22:33
…ity directly. Also, update BlobTriggerFunction to read blobstream and do document analysis on read chunks.
@amisi01 amisi01 force-pushed the users/amisi/useridentitychanges branch from 242bb42 to 297e867 Compare August 23, 2024 07:23
Copy link
Contributor

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, but overall looking close.

DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
deployment/functionapp.bicep Show resolved Hide resolved
DocumentVectorPipelineFunctions/BlobTriggerFunction.cs Outdated Show resolved Hide resolved
@amisi01 amisi01 force-pushed the users/amisi/useridentitychanges branch from b710197 to 56cfd5e Compare August 25, 2024 01:50
@amisi01 amisi01 force-pushed the users/amisi/useridentitychanges branch from 56cfd5e to 1410b76 Compare August 25, 2024 01:56
@amisi01 amisi01 merged commit 83149af into main Aug 25, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants