MSAL Node - HttpClient Proxy Improvements #6987
Conversation
Robbie-Microsoft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
bgavrilMS,
trwalke,
pmaytak,
gladjohn,
rayluo and
Avery-Dunn
as code owners
github-actions
bot
added
documentation
| @@ -72,6 +78,7 @@ export class HttpClient implements INetworkModule { | |||
| this.proxyUrl, | |||
| HttpMethod.POST, | |||
| options, | |||
| this.customAgent as http.Agent, | |||
There was a problem hiding this comment.
What if the customer configured https.Agent? Should you not throw an exception with a good error message explaining how to configure these?
There was a problem hiding this comment.
I made some improvements to address this.
Take a look at this stack overflow post.
https.Agent internally calls and constructs with http.Agent
I interpret this as meaning either one can be used. Look at my improvements and let me know your thoughts.
| @@ -80,6 +87,7 @@ export class HttpClient implements INetworkModule { | |||
| url, | |||
| HttpMethod.POST, | |||
| options, | |||
| this.customAgent as https.Agent, | |||
There was a problem hiding this comment.
How will this work with MSI? Calls to MSI are done over http.
I don't expect anyone to define a proxy for calling MSI. That can be unsupported scenario.
There was a problem hiding this comment.
My improvements should address this.
I'll be testing this shortly on my Windows laptop with Fiddler, to simulate a proxy. I'm also going to to ask the user who filed the linked issue to test this. |
Added
customAgentto msal-node system options so custom http(s) agents can be used by the HttpClient. This allows devs to use agents created by third party libraries (useful for proxy support).Added support for authenticated proxy.
NOTE: faq.md was automatically linted. The only change is on line 75.