Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perf issue #8

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix perf issue #8

merged 2 commits into from
Aug 15, 2024

Conversation

Binyang2014
Copy link
Collaborator

@Binyang2014 Binyang2014 commented Aug 14, 2024

Reduce DAG travel time complexity from O(n^2) to O(n).
Since _complete_metadata needs to calculate depth, the time complexity is still O(n^2). Just removed unnecessary branches

@Binyang2014 Binyang2014 requested a review from yzygitzh August 14, 2024 11:12
@Binyang2014 Binyang2014 marked this pull request as ready for review August 14, 2024 11:12
@Binyang2014 Binyang2014 merged commit 52a226b into main Aug 15, 2024
15 checks passed
@Binyang2014 Binyang2014 deleted the binyli/fix branch August 15, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants