Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactor for mscclang #3

Merged
merged 76 commits into from
May 7, 2024
Merged

Code refactor for mscclang #3

merged 76 commits into from
May 7, 2024

Conversation

Binyang2014
Copy link
Collaborator

@Binyang2014 Binyang2014 commented Apr 29, 2024 •
edited
Loading

Refactor msccl-tools code.

  • Add regression test which compares generated results between current commit and main branch
  • For rank_dag.py, change it to instruciton_dag.py. Add base class InstructionDAG with common functions. Some msccl related function move to MscclInstructionDAG class
  • Refactor ir.py. Move common types to types.py
  • Format some file with black

@Binyang2014 Binyang2014 marked this pull request as ready for review April 30, 2024 01:57
@Binyang2014 Binyang2014 changed the title Refactor Code refactor for mscclang Apr 30, 2024
yzygitzh
yzygitzh reviewed Apr 30, 2024
View reviewed changes
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
msccl/language/__init__.py Show resolved Hide resolved
msccl/language/instruction_dag.py Show resolved Hide resolved
msccl/language/instruction_dag.py Show resolved Hide resolved
msccl/language/types.py Outdated Show resolved Hide resolved
@yzygitzh
Copy link
Collaborator

One general comment: shall we give an overview of key changes in commit message? (aka description of this PR)

Andyli1007
Andyli1007 suggested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Andyli1007 Andyli1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest using configurable main when running the pipeline

@Binyang2014 Binyang2014 merged commit 3bfba6b into main May 7, 2024
15 checks passed
@Binyang2014 Binyang2014 deleted the binyli/refactory branch August 26, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andyli1007 Andyli1007 Andyli1007 approved these changes

@yzygitzh yzygitzh yzygitzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Binyang2014 @yzygitzh @Andyli1007