Add skipIISCustomErrors switch to iisnode #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 3, 2017 14:44
IHTTPResponse::SetStatus needs to be called with fTrySkipCustomErrors flag set in order for iisnode to bypass IIS custom errors when errorMode="Auto" Add opt-in skipIISCustomErrors switch to iisnode configuration. Users can opt into the fTrySkipCustomErrors flag behavior with skipIISCustomErrors="true". If this option is not specified, then the default behavior will match the previous behavior before this change. skipIISCustomErrors behavior was left out of SendEmptyResponse Internal iisnode errors should probably not set fTrySkipCustomErrors since these are just empty status responses. Let IIS capture and replace these responses with more detailed messages depending on the custom error mode.
|
@mparq This looks great! I'd be really keen to see this merged. Would you mind signing the CLA? (I'm assuming that's the only blocker to get this merged, maybe @rramachand21 could comment on that) |
|
Hi @rupesh1 , Sorry, I stopped checking my github notifications a while ago last year so I just came across this comment. CLA has been signed! I'd love to see this merged in, too. Thanks! |
|
Hello, I find the functionality very important. @Azure could you please merge this pull request into the main stream or comment, why it cannot be done? Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
My team recently switched to using your fork of iisnode since it seems to be still maintained. I had to merge my changes for skipping IIS custom errors into your fork so I figured I'd send a PR while I was at it.
IHTTPResponse::SetStatus needs to be called with fTrySkipCustomErrors flag set in
order for iisnode to bypass IIS custom errors when errorMode="Auto"
Add opt-in skipIISCustomErrors switch to iisnode configuration.
Users can opt into the fTrySkipCustomErrors flag behavior with skipIISCustomErrors="true".
If this option is not specified, then the default behavior will match the previous behavior before this change.
skipIISCustomErrors behavior was left out of SendEmptyResponse
Internal iisnode errors should probably not set fTrySkipCustomErrors since these are just empty status responses.
Let IIS capture and replace these responses with more detailed messages depending on the custom error mode.
For more info, see my comment on tjanczuk#476.