Add recover for panics from handlers #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so we no longer need to manually build the frontend image. It also means we don't need to use dockerd as the builder for these targets to work. Signed-off-by: Brian Goff <[email protected]>
This is not actually helping anything and is actively causing issues on CI right now. We already removed the same thing in integration tests, this just brings this into the e2e tests. Signed-off-by: Brian Goff <[email protected]>
This allows the error to actually propagate back to the client instead of the ominous "exit code 2" and having to search through the daemon logs to see what happened. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
panic_recover
branch
from
6e9a445 to
a4bc43d
Compare
adamperlin
reviewed
Jan 25, 2025
| "DALEC_DISABLE_DIFF_MERGE" = DALEC_DISABLE_DIFF_MERGE | ||
| } | ||
| contexts = { |
There was a problem hiding this comment.
Does this mean the frontend needs to be passed as a build context?
There was a problem hiding this comment.
This meas the bake target is passing the frontend as a build context and then the build-arg tells it to read the frontend from the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the error to actually propagate back to the client instead of the ominous "exit code 2" and having to search through the daemon logs to see what happened.
Closes #181