Added properly error message for system to system container copy #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphulkar-msft
requested review from
gapra-msft,
adreed-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
…into dphulkar/syscontainer
…into dphulkar/syscontainer
…into dphulkar/syscontainer
| if cca.FromTo.IsS2S() { | ||
| dstContainerName, err := GetContainerName(cca.Destination.Value, cca.FromTo.To()) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get container name from destination (is it formatted correctly?)") |
There was a problem hiding this comment.
should we add the err with %w to the print statement?
| // @brief Thia API check if the container name provided is a system container or not | ||
| func IsSystemContainer(containerName string) bool { | ||
| // define the system variables for the system containers | ||
| systemContainers := []string{"$blobchangefeed", "$logs"} |
There was a problem hiding this comment.
These containers as destination of copy shall be errored out but as source it shall still work. Add test cases around such combinations in E2E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customers attempt to copy $blobchangefeed in a source to $blobchangefeed in a destination.
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
We should allow copy of system containers to non-system containers, but need better error messaging for system container to system container copies when customers try to execute
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Manual Testing
Thank you for your contribution to AzCopy!