Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed jobs clean broken command #2850

Merged
merged 10 commits into from
Nov 19, 2024
Merged

Fixed jobs clean broken command #2850

merged 10 commits into from
Nov 19, 2024

Conversation

dphulkar-msft
Copy link
Collaborator

@dphulkar-msft dphulkar-msft commented Nov 4, 2024 •
edited
Loading

Azcopy job cleanup is blocked by its own log file deletion.

Fix: azcopy jobs clean command should delete all the log files except the running job's log file.

@vibhansa-msft vibhansa-msft added this to the 10.28.0 milestone Nov 4, 2024
gapra-msft
gapra-msft approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@gapra-msft gapra-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the last comment I added, otherwise the PR looks good

@dphulkar-msft dphulkar-msft merged commit be923c6 into main Nov 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gapra-msft gapra-msft gapra-msft approved these changes

@vibhansa-msft vibhansa-msft vibhansa-msft approved these changes

@adreed-msft adreed-msft Awaiting requested review from adreed-msft adreed-msft is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@souravgupta-msft souravgupta-msft Awaiting requested review from souravgupta-msft souravgupta-msft is a code owner

@tanyasethi-msft tanyasethi-msft Awaiting requested review from tanyasethi-msft tanyasethi-msft is a code owner

Assignees

@gapra-msft gapra-msft

@vibhansa-msft vibhansa-msft

Labels
None yet
Projects
None yet
Milestone
10.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dphulkar-msft @gapra-msft @vibhansa-msft