Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Detach for AMQP message receiver; Remove MessageReceiver from an Arc because it doesn't need to be in one. #1927

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LarryOsterman
Copy link
Member

  • Implemented AmqpReceiver::detach to allow clean shutdown of message receiver.
  • Ignore ClosedByRemote error when handling a sender detach - that can happen.
  • Removed a dead max_message_size method from AMQP Receiver.
  • Minor tweaks to imports caused by removing blank lines to let rustfmt handle all imports consistently.

Github Summary.

This pull request includes several changes to the sdk/core/azure_core_amqp crate, focusing on improving the handling of receiver and sender detachment, updating imports, and removing unused methods. The most important changes include modifying the detachment process for receivers and senders, updating import statements, and removing the max_message_size method from the AmqpReceiverApis trait.

Improvements to receiver and sender detachment:

Updates to imports:

Removal of unused methods:

@LarryOsterman LarryOsterman changed the title Fixes to AMQP messenger for C++ code Fixes to AMQP messenge receiver for C++ code Nov 22, 2024
@LarryOsterman LarryOsterman changed the title Fixes to AMQP messenge receiver for C++ code Implement Detach for AMQP message receiver; Remove MessageReceiver from an Arc because it doesn't need to be in one. Nov 25, 2024
@LarryOsterman
Copy link
Member Author

Ping. Hopefully someone can take a look :).

@LarryOsterman LarryOsterman enabled auto-merge (squash) November 25, 2024 21:10
sdk/core/azure_core_amqp/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants