Implement Detach for AMQP message receiver; Remove MessageReceiver from an Arc because it doesn't need to be in one. #1927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AmqpReceiver::detach
to allow clean shutdown of message receiver.Github Summary.
This pull request includes several changes to the
sdk/core/azure_core_amqp
crate, focusing on improving the handling of receiver and sender detachment, updating imports, and removing unused methods. The most important changes include modifying the detachment process for receivers and senders, updating import statements, and removing themax_message_size
method from theAmqpReceiverApis
trait.Improvements to receiver and sender detachment:
sdk/core/azure_core_amqp/src/fe2o3/receiver.rs
: Modified thedetach
method in theimpl AmqpReceiverApis for Fe2o3AmqpReceiver
to handle errors more gracefully and log appropriate messages.sdk/core/azure_core_amqp/src/fe2o3/sender.rs
: Modified thedetach
method in theimpl AmqpSenderApis for Fe2o3AmqpSender
to handle errors more gracefully and log appropriate messages.Updates to imports:
sdk/core/azure_core_amqp/src/fe2o3/receiver.rs
: Updated import statements to includeAmqpLinkDetach
and additional logging utilities.sdk/core/azure_core_amqp/src/fe2o3/sender.rs
: Updated import statements to includeAmqpLinkDetach
and additional logging utilities.Removal of unused methods:
sdk/core/azure_core_amqp/src/receiver.rs
: Removed themax_message_size
method from theAmqpReceiverApis
trait.sdk/core/azure_core_amqp/src/noop.rs
: Removed themax_message_size
method from theimpl AmqpReceiverApis for NoopAmqpReceiver
.