Show full Entra error description on auth failure #4585
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyCA
requested review from
ellismg,
wbreza,
vhvb1989,
hemarina and
weikanglim
as code owners
vhvb1989
reviewed
Nov 25, 2024
|
Thanks for sharing the screen shots, @JeffreyCA! One of the things that jumped out at me with them (which I don't think is a problem introduced by this PR) is that the suggestion text is sort of hard to find, especially with the large amount of red text before. In a future PR we might want to introduce some whitespace (and maybe some color?) to help it pop a little more - just my two cents. |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Sure, I created an issue #4589 for this. |
vhvb1989
approved these changes
Nov 26, 2024
JeffreyCA
commented
Nov 26, 2024
| if slices.Contains((response.ErrorCodes), 50005) { | ||
| e.loginCmd += " --use-device-code=false" | ||
| // TODO: Use aka.ms short link | ||
| e.helpLink = "https://learn.microsoft.com/azure/developer/azure-developer-cli/troubleshoot#azd-pipeline-config-failure-due-to-conditional-access-policy" |
There was a problem hiding this comment.
I'm not familiar with our aka.ms naming conventions - @alexwolfmsft could you or someone help create an aka.ms shortlink that points to this URL?
There was a problem hiding this comment.
I'm wondering if the user may not have ran pipeline config here at all; while the documentation we provide here would be specific to pipeline config.
weikanglim
reviewed
Dec 2, 2024
| if slices.Contains((response.ErrorCodes), 50005) { | ||
| e.loginCmd += " --use-device-code=false" | ||
| // TODO: Use aka.ms short link | ||
| e.helpLink = "https://learn.microsoft.com/azure/developer/azure-developer-cli/troubleshoot#azd-pipeline-config-failure-due-to-conditional-access-policy" |
There was a problem hiding this comment.
I'm wondering if the user may not have ran pipeline config here at all; while the documentation we provide here would be specific to pipeline config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4559 so that the full Entra error description is shown to the user when there's an auth failure. In addition, the instruction text to reauthenticate is now wrapped in a suggestion.
Existing behaviour:
New behaviour:
