Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new): Added Azure.LogAnalytics.Replication #2894

Conversation

BenjaminEngeset
Copy link
Contributor

PR Summary

Fixes #2893

Added Azure.LogAnalytics.Replication.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BenjaminEngeset BenjaminEngeset requested a review from a team as a code owner May 28, 2024 09:43
@BenjaminEngeset
Copy link
Contributor Author

Hi @BernieWhite,

Could you please share your thoughts on this? Initially, I believed that Azure.Monitor.Workspace.Replication was the appropriate approach. However, upon further consideration, I am wondering if it would be better to separate each “sub-service.” Given the extensive nature of the Azure Monitor portfolio and its potential for further growth, this might provide better scalability and organization.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminEngeset. Great work.

There is a few suggestions below. Any questions let me know.

src/PSRule.Rules.Azure/rules/Azure.LogAnalytics.Rule.yaml Outdated Show resolved Hide resolved
docs/en/rules/Azure.LogAnalytics.Replication.md Outdated Show resolved Hide resolved
docs/en/rules/Azure.LogAnalytics.Replication.md Outdated Show resolved Hide resolved
docs/en/rules/Azure.LogAnalytics.Replication.md Outdated Show resolved Hide resolved
src/PSRule.Rules.Azure/rules/Azure.LogAnalytics.Rule.yaml Outdated Show resolved Hide resolved
@BernieWhite
Copy link
Collaborator

Hi @BernieWhite,

Could you please share your thoughts on this? Initially, I believed that Azure.Monitor.Workspace.Replication was the appropriate approach. However, upon further consideration, I am wondering if it would be better to separate each “sub-service.” Given the extensive nature of the Azure Monitor portfolio and its potential for further growth, this might provide better scalability and organization.

I'm fine with this approach. Currently we group by resource.

@BenjaminEngeset
Copy link
Contributor Author

Check the latest changes @BernieWhite. Should be all good to merge.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminEngeset. All good to merge.

@BernieWhite BernieWhite merged commit 0e8ad12 into Azure:main May 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RULE] Log Analytics workspaces should have workspace replication enabled to improve service availability
2 participants