Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added december baselines #2580 #2602

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Added december baselines #2580 #2602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
806dab7
Added december baselines #2580
BernieWhite Dec 12, 2023
0b99cc6
Merge branch 'main' into users/bewhite/update-baselines-dec
BernieWhite Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/CHANGELOG-v1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ See [upgrade notes][1] for helpful information when upgrading from previous vers

What's changed since pre-release v1.32.0-B0053:

- New features:
- Added December 2023 baselines `Azure.GA_2023_12` and `Azure.Preview_2023_12` by @BernieWhite.
[#2580](https://github.com/Azure/PSRule.Rules.Azure/issues/2580)
- Includes rules released before or during December 2023.
- Marked `Azure.GA_2023_09` and `Azure.Preview_2023_09` baselines as obsolete.
- Updated rules:
- App Configuration:
- Promoted `Azure.AppConfig.GeoReplica` to GA rule set by @BernieWhite.
Expand Down
61 changes: 61 additions & 0 deletions src/PSRule.Rules.Azure/rules/Baseline.Rule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,8 @@ apiVersion: github.com/microsoft/PSRule/v1
kind: Baseline
metadata:
name: Azure.GA_2023_09
annotations:
obsolete: true
spec:
configuration:
# Configure minimum AKS cluster version
Expand Down Expand Up @@ -554,6 +556,64 @@ apiVersion: github.com/microsoft/PSRule/v1
kind: Baseline
metadata:
name: Azure.Preview_2023_09
annotations:
obsolete: true
spec:
rule:
tag:
release: preview
ruleSet:
- '2020_06'
- '2020_09'
- '2020_12'
- '2021_03'
- '2021_06'
- '2021_09'
- '2021_12'
- '2022_03'
- '2022_06'
- '2022_09'
- '2022_12'
- '2023_03'
- '2023_06'
- '2023_09'

---
# Synopsis: Include rules released December 2023 or prior for Azure GA features.
apiVersion: github.com/microsoft/PSRule/v1
kind: Baseline
metadata:
name: Azure.GA_2023_12
spec:
configuration:
# Configure minimum AKS cluster version
AZURE_AKS_CLUSTER_MINIMUM_VERSION: '1.27.7'
rule:
tag:
release: GA
ruleSet:
- '2020_06'
- '2020_09'
- '2020_12'
- '2021_03'
- '2021_06'
- '2021_09'
- '2021_12'
- '2022_03'
- '2022_06'
- '2022_09'
- '2022_12'
- '2023_03'
- '2023_06'
- '2023_09'
- '2023_12'

---
# Synopsis: Include rules released December 2023 or prior for Azure preview only features.
apiVersion: github.com/microsoft/PSRule/v1
kind: Baseline
metadata:
name: Azure.Preview_2023_12
spec:
rule:
tag:
Expand All @@ -573,3 +633,4 @@ spec:
- '2023_03'
- '2023_06'
- '2023_09'
- '2023_12'
14 changes: 14 additions & 0 deletions tests/PSRule.Rules.Azure.Tests/Azure.Baseline.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,5 +215,19 @@ Describe 'Baselines' -Tag Baseline {
$filteredResult | Should -Not -BeNullOrEmpty;
$filteredResult.Length | Should -Be 13;
}

It 'With Azure.GA_2023_12' {
$result = @(Get-PSRule -Module PSRule.Rules.Azure -Baseline 'Azure.GA_2023_12' -WarningAction Ignore);
$filteredResult = @($result | Where-Object { $_.Tag.release -in 'GA'});
$filteredResult | Should -Not -BeNullOrEmpty;
$filteredResult.Length | Should -Be 394;
}

It 'With Azure.Preview_2023_12' {
$result = @(Get-PSRule -Module PSRule.Rules.Azure -Baseline 'Azure.Preview_2023_12' -WarningAction Ignore);
$filteredResult = @($result | Where-Object { $_.Tag.release -in 'preview'});
$filteredResult | Should -Not -BeNullOrEmpty;
$filteredResult.Length | Should -Be 13;
}
}
}
Loading