Skip comparing parameter values that are both null (#540) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelschwitter
force-pushed
the
fix/540-trigger-payload-empty-array-issue
branch
from
87cd66b to
cd9d4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature that "[]" evaluates to
$nullwhen passed intoConvertFrom-Json,Compare-Objectthrows an error that the ReferenceObject cannot be null.This change first compares the deployedObject and payloadObject if both are non-null and only then passes the two object to
Compare-Object.If one of the objects is null and the other is not, it will still throw an error, but the script will still stop the triggers as before which is good in this case (null != non-null).
For more details, see #540