-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add parameters and improvements for PrePostDeploymentScript.Ver2.ps1 to fix datetime issue and support override of parameters #498
base: main
Are you sure you want to change the base?
Conversation
@gvdmaaden please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
@soma-ms - Since you are the main contributor of this powershell script can you perhaps review this pr and advise? If this pr is too big then maybe switching to a v3 version of the script is justified? |
@gvdmaaden - I appreciate contributing to the script. This script will also pushed to the artifacts generated through automated publish feature in ADF, so need to be thoroughly tested and any regression will have large impact as there are large no customers have CICD workflows using automated publish. The PR has too many changes. I would suggest to have separate PRs for fix and features, so can be taken up as appropriate. |
Add three new parameters:
Boolean that controls if you want to cleanup ADF artifacts that are not present in the provided ARM template
Boolean that controls if you want to start all stopped triggers on ADF, or only the triggers mentioned in the ARM template with runtimeState "Started"
Parameter to override the ARM template parameters. Similar to overrideParameters in AzureResourceGroupDeployment@2
In the function Update-TriggerTemplate there is some extra logic to correctle handle datetime values that were provided thru the override. This parameter should fix this issue: Predeployment (PrePostDeploymentScript.Ver2.ps1) powershell script stops all blob triggers #467
Add workaround for the local time issue in Get-AzDataFactoryV2Pipeline (see #469 and Azure/azure-powershell#20474), see line 295 till 309
This workaround can be removed as soon as the azure-powershell team fixed this issue.
Add additional Write-Host log output to get a better idea of the changes between the ARM template and the deployed version.