Fix prepdocs compatibility with openai key and add test #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
commented
Aug 31, 2023
scripts/prepdocs.py
Outdated
| yield section | ||
|
|
||
| def before_retry_sleep(retry_state): | ||
| if args.verbose: print("Rate limited on the OpenAI embeddings API, sleeping before retrying...") | ||
|
|
||
| @retry(wait=wait_random_exponential(min=1, max=60), stop=stop_after_attempt(15), before_sleep=before_retry_sleep) | ||
| def compute_embedding(text): | ||
| @retry(retry=retry_if_exception_type(openai.error.RateLimitError), wait=wait_random_exponential(min=1, max=60), stop=stop_after_attempt(15), before_sleep=before_retry_sleep) |
There was a problem hiding this comment.
This was also retrying for AuthenticationError before, so I've made it more specific now. No sense retrying 15 times for an auth error.
pamelafox
commented
Aug 31, 2023
scripts/prepdocs.py
Outdated
| wait_random_exponential, | ||
| ) | ||
|
|
||
| args = argparse.Namespace(verbose=False) |
There was a problem hiding this comment.
I would prefer to not have args be a global at all, but at least this makes it possible to test.
|
Re-created in #605 |
ratkinsoncinz
pushed a commit
to cinzlab/govgpt-azure-search-openai-demo
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an issue mentioned in #431 (comment), adds tests for compute_embedding, and fixes an issue I found while writing tests.
I also made a few changes to increase the testability of prepdocs.py, like reducing the number of globals.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test