Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Conversation History, "Vanilla" chat page, and tweaked local dev settings for hot swap #259

Closed
wants to merge 67 commits into from

Conversation

bdleavitt
Copy link

Purpose

Deploying module deploys CosmosDB instance for storing conversation history. Uses Azure app service's built-in authentication to separate user conversations from each othe.r

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Initialize repo azd init
deploy infra azd up
Enable auth on app service

  • Test the code
    Open website. Navigate to "ChatGPT" tab.

What to Check

Verify that the following are valid

  • Enter a prompt and get a response on the ChatGPT page.
  • Click on the "Conversation List" to make sure the conversation is saved.
  • Try to delete the conversation and verify it drops out of the list.

Other Information

bdleavitt and others added 30 commits April 24, 2023 12:46
Not actually keyvault, but adding placeholder ocmponents in JSX for ChatGPT page. Issue/1 add keyvault
fixed typo in azure.yaml was breaking azd deploy
Add "Design/Wiki Reference" to ISSUE_TEMPLATE #20
@apiontek apiontek mentioned this pull request Dec 20, 2023
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed.

@github-actions github-actions bot added the Stale label Dec 22, 2023
@nits-aidev
Copy link

nits-aidev commented Apr 15, 2024

Hi @pamelafox , This feature is most asked and I think this is the only feature missing from this repository , Rest everything already covered , Can you add this one as well?

Issues #977 #489 , Also this PR will help in fixing may other relatable issue with chat history.

@bdleavitt , This pull request needs to be updated since the code has been significantly modified.

@pamelafox
Copy link
Collaborator

We'll try to get to this in the near future. Currently, our priority is ironing out issues with existing features, particularly user authentication, upload, and GPT-4-vision. But I agree that this would be a good feature to bring this app to feature parity with other RAG solutions.

@MayankSingh173
Copy link

@bdleavitt Could you please attach a demo to this PR? We would also like to add this feature in our application

@fujita-h fujita-h mentioned this pull request Sep 25, 2024
5 tasks
@pamelafox
Copy link
Collaborator

Thanks @bdleavitt for this PR from a year ago, for inspiring many future PRs!
We just released CosmosDB chat history today:
https://github.com/Azure-Samples/azure-search-openai-demo/releases/tag/2024-11-12
And we have a pending PR for "vanilla" chat:
#2123
I'm going to close this PR since there are more recent versions of the same features, but wanted to reiterate a big thank you for showing devs how to make these changes and offering up your branch in a PR.

@pamelafox pamelafox closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants