-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Container Apps as a host option #1952
Conversation
Check Country Locale in URLsWe have automatically detected added country locale to URLs in your files. Check the file paths and associated URLs inside them. For more details, check our Contributing Guide.
|
Check Country Locale in URLsWe have automatically detected added country locale to URLs in your files. Check the file paths and associated URLs inside them. For more details, check our Contributing Guide.
|
Check Country Locale in URLsWe have automatically detected added country locale to URLs in your files. Check the file paths and associated URLs inside them. For more details, check our Contributing Guide.
|
Check Country Locale in URLsWe have automatically detected added country locale to URLs in your files. Check the file paths and associated URLs inside them. For more details, check our Contributing Guide.
|
Thanks for the PR! We do want to optionally support ACA deployment, and I had a branch that did that las year, but I want to make sure it's maintainable. A few questions:
cc @tonybaloney who's been working on the AVM effort, |
|
Hi @pamelafox, my current problem is that after putting aca's azure.yaml in a subfolder, the scripts referenced in the azure.yaml report error because they are written with paths relative to cwd that assumes they are called from project root like this one. To workaround this, I create some symlinks to My questions are: 2.What do you think about the unified approach for supporting different deployment target in this repo azure-search-openai-demo-java/deploy at main · Azure-Samples/azure-search-openai-demo-java (github.com) |
…der instead of cwd
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.
|
The description is referring to a bunch of symlinks and an "aca-host" folder that doesn't exist. Is this outdated? |
@mattgotteiner Yes, sorry, we've had a lot of offthread discussion, both with Yefu and with the azd team. I really wanted to make sure that we kept the azd environment in ".azure" at the root, and to reduce our maintenance burden, so I voted for using the approach of the comment in azure.yaml. |
Got it. Any way to update the description? |
@mattgotteiner I've updated it to reflect current approach |
I merged in main after committing the Bicep formatting changes there, so main.bicep only has ACA related changes now. |
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.
|
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.
|
Update: I had to modify our logic in app.py for selecting which credential to use, as we recently changed that to specifically use ManagedIdentityCredential. My latest deploy isn't working with the change, as it says "azure.core.exceptions.ClientAuthenticationError: (None) Unable to load the proper Managed Identity." If you have time to debug it, let me know if you see the issue. |
Update: It's working for me now when I change ManagedIdentityCredential to azure_credential = ManagedIdentityCredential(client_id=os.getenv("AZURE_CLIENT_ID")) But it's strange that it's not correctly finding AZURE_CLIENT_ID. That works for me in other samples. Anyway, I guess it's fine to add yet another if condition for the AZURE_CLIENT_ID existence. |
Sorry, I just come back from holiday. According to microsoft/azure-container-apps#442,
My guess is that you are using SAMI in other samples, which explains why they work without passing client id to |
be27f5a
to
fa57654
Compare
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.
|
fa57654
to
8d3edb0
Compare
Looking good! I did a test deploy to ACA and app service. I'll merge tomorrow. |
Add Azure Container Apps as a host option (Azure-Samples#1952)
Purpose
Hi maintainers, thank you for making this great sample. I'm with Azure Container Apps team and trying to add Azure Container Apps as a host option.
Due to a limitation of azd, only one azure.yaml file can exist in the project root folder and there's no way to define both ACA and AppService in it at the same time.
This PR initially suggested using a separate folder for the ACA azure.yaml, but that had the drawback of affecting relative paths for scripts and affecting the ability to fetch the azd environment variables.
After discussion with Pamela, we decided to use the approach of a commented out line in the root azure.yaml. That minimizes the amount of redudant files needed, and makes sure that the azd environment stays in the root .azure/ folder.
Does this introduce a breaking change?
The changes are isolated in new files and folders. So I believe there will not be any breaking changes.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
No python code changes.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added linespython -m mypy
to check for type errorsruff
andblack
manually on my code.