Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust getting started #93

Merged
merged 6 commits into from
Feb 29, 2024
Merged

rust getting started #93

merged 6 commits into from
Feb 29, 2024

Conversation

olivakar
Copy link
Contributor

First rust sample for basic getting started scenario

Copy link
Contributor

@rido-min rido-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR !! just a few nits:

  1. Solve branch conflicts
  2. Add cargo.toml at the root
  3. Refactor getting started to move common code (like TLS) to mqttclients

@olivakar
Copy link
Contributor Author

Adding cargo.toml at the root does not work with the existing cargo commands. So for now I am not doing that. Any cargo file needs to be tied to the rest of the cargo files.

@rido-min
Copy link
Contributor

rido-min commented Feb 23, 2024

Adding cargo.toml at the root does not work with the existing cargo commands. So for now I am not doing that. Any cargo file needs to be tied to the rest of the cargo files.

sure, and the cargo.tom at the root should reference all the other cargo.toml

Can you try to find a sample on how to do it correctly?

-- Added a workspace cargo

@olivakar olivakar changed the title Ok/rust getting started rust getting started Feb 23, 2024
@rido-min
Copy link
Contributor

@andyk-ms I saw you approved the PR without my suggestions to refactor the TLS code into the mqttclients lib.

Do you want to get this merged now and do the refactor later?

I'd prefer to complete this PR with the proper helper methods to avoid the code duplication we have in Python.

@olivakar olivakar merged commit b7f68c9 into main Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants