Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - fix note #84

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Update README.md - fix note #84

merged 1 commit into from
Feb 26, 2024

Conversation

ryanwinter
Copy link
Contributor

Purpose

  • ...

Checklist

  • I have read the contribution guidelines.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the main branch.
    • I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
    • I will squashed my changes into one with a clear description of the change when I complete the PR.

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • ...

What to Check

Verify that the following are valid

  • ...

Other Information

@ryanwinter ryanwinter requested a review from vaavva November 28, 2023 20:15
@rido-min
Copy link
Contributor

@ryanwinter this PR has approved since Nov.. any blockers to get it merged?

@ryanwinter ryanwinter merged commit 42fadb8 into main Feb 26, 2024
3 checks passed
@ryanwinter ryanwinter deleted the ryanwinter-patch-1 branch February 26, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants