chore: Minor Gemini updates in prep for more general shifts #11292
+140
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledwards2225
force-pushed
the
lde/concatenate_2
branch
from
58b2217 to
edf254f
Compare
ledwards2225
commented
Jan 20, 2025
| @@ -163,24 +163,29 @@ TYPED_TEST(ShpleminiTest, CorrectnessOfGeminiClaimBatching) | |||
| } | |||
|
|
|||
| for (auto& poly : pcs_instance_witness.to_be_shifted_polynomials) { | |||
| batched_unshifted.add_scaled(poly, rhos[idx]); | |||
| batched_to_be_shifted.add_scaled(poly, rhos[idx]); | |||
There was a problem hiding this comment.
I think this was just a bug in the test?
|
superceded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the Gemini code was confusing in a number of ways. (1) The methods did not really do what they said they did. e.g.